Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Doesn't support authentication #19

Closed
DarwinAwardWinner opened this issue Jan 20, 2016 · 10 comments
Closed

Doesn't support authentication #19

DarwinAwardWinner opened this issue Jan 20, 2016 · 10 comments

Comments

@DarwinAwardWinner
Copy link

I have some web pages on my personal server, e.g. Transmission, that require HTTP authentication before loading the page. When I try to package these as apps using nativefier, they just give a 401 page without any login prompt.

@jiahaog
Copy link
Member

jiahaog commented Jan 20, 2016

It appears that Electron supports this since electron/electron#3250, I'll look into implementing this with a small window, thanks for the feedback!

@tennisgent
Copy link

I got this same thing with feedly.com. I tried to wrap it and the application works beautifully, until I try to login. It requires OAuth2 authentication, which requires that the application open a separate tab for the OAuth2 provider (Google, Facebook, etc). When the application tries to open this window, the authentication page opens in Chrome, which never gets back to the application to store the cookie.

Otherwise, this is a very sweet tool! Thanks for putting it together. :)

@dansowter
Copy link

Same issue for Facebook auth while "nativefier"ing Habitica.

jiahaog added a commit that referenced this issue Jan 21, 2016
…renced in #19

- Issue #19 (comment)
- When a link that requests a new window is clicked, the app will check if the link is an external link. If so, the default desktop browser (Chrome, Safari etc.) will be opened. Otherwise, a new Electron BrowserWindow will be opened, which supports the use case of logging in to OAuth websites such as feedly.com
@mdamjanic7
Copy link

I've tested this with Feedly, and it works great, but when trying to do Google log in to Asana (app.asana.com), it simply opens a Safari window, and stays there.

@jiahaog jiahaog reopened this Jan 23, 2016
@jiahaog jiahaog added the bug label Jan 23, 2016
@DarwinAwardWinner
Copy link
Author

My original report was about basic HTTP authentication dialogs. I'd imagine that Google/Facebook/etc. logins that open separate browser windows would require a completely different fix.

@jiahaog
Copy link
Member

jiahaog commented Jan 29, 2016

You can now use the right click context menu to force certain authentication links to open in the same Electron process, and hence login will work for most OAuth sites.

@mdamjanic7 Asana seems to be an exception and I have no idea how to get it to work there though :(

@jiahaog
Copy link
Member

jiahaog commented Feb 18, 2016

If anyone can figure out how to get certain OAuth sites like Asana to work please voice out, closing this issue for now.

@jiahaog
Copy link
Member

jiahaog commented Mar 14, 2016

I've created #164 which consolidates all problems with logging in!

@tianhuil
Copy link

tianhuil commented Apr 3, 2019

This is a narrow-cast solution which wokred for me and keeps non-google-login links opening externally for asana:

nativefier --name "Asana" --internal-urls "accounts\.google\.com.*" https://app.asana.com/

@oVertoneTyler
Copy link

nativefier --name "Asana" --internal-urls "accounts\.google\.com.*" https://app.asana.com/

superb.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants