This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Restore login functionality broken since Electron 5.x #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodeIntegration is required if eg. Javascript code makes use of the `require` expression to import classes into the current scope. login.js uses an electron import - without it, the callback mechanism does not work, and thus the whole login functionality.
ronjouch
changed the title
|
@kiesel thanks! Merging. |
Closed
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
) nodeIntegration is required if eg. Javascript code makes use of the `require` expression to import classes into the current scope. login.js uses an electron import - without it, the callback mechanism does not work, and thus the whole login functionality. Electron seems to have changed the default value for a windows `nodeIntegration` to `false` since version 5 (see https://stackoverflow.com/questions/55093700/electron-5-0-0-uncaught-referenceerror-require-is-not-defined) Without the integration, the login component's functionality is broken, though. This PR enables the nodeIntegration feature for the login window and makes it properly propagate the given credentials. Tested with Electron 6.0.0 on Linux.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeIntegration is required if eg. Javascript code makes use of the
requireexpression to import classes into the current scope. login.jsuses an electron import - without it, the callback mechanism does not
work, and thus the whole login functionality.
Electron seems to have changed the default value for a windows
nodeIntegrationtofalsesince version 5 (see https://stackoverflow.com/questions/55093700/electron-5-0-0-uncaught-referenceerror-require-is-not-defined)Without the integration, the login component's functionality is broken, though. This PR enables the nodeIntegration feature for the login window and makes it properly propagate the given credentials.
Tested with Electron 6.0.0 on Linux.