Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 Support #38

Closed
fgaim opened this issue Jun 21, 2018 · 1 comment
Closed

Python 3 Support #38

fgaim opened this issue Jun 21, 2018 · 1 comment

Comments

@fgaim
Copy link

fgaim commented Jun 21, 2018

Thanks for the nice work. A minor issue, you have implemented support for Python 3 by catching the ModuleNotFoundError exception, which is fine for Python version 3.6 but will cause an error in versions <=3.5.

A quick solution would be to use ImportError instead of ModuleNotFoundError, at lines 24 and 14 in main.py and utils/data.py, respectively.
@jiesutd
Copy link
Owner

jiesutd commented Jun 21, 2018

Fixed, thank you very much! @fgaim

@jiesutd jiesutd closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fgaim @jiesutd