Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeclarativeColumnsMetaclass.__new__ should super-call #57

Closed
mwhudson opened this issue Mar 8, 2012 · 1 comment
Closed

DeclarativeColumnsMetaclass.__new__ should super-call #57

mwhudson opened this issue Mar 8, 2012 · 1 comment

Comments

@mwhudson
Copy link

mwhudson commented Mar 8, 2012

If you want a subclass of Table to have a metaclass such as ABCMeta, you need to subclass both DeclarativeColumnsMetaclass and the other class. Because DeclarativeColumnsMetaclass just calls type.new rather than super(DeclarativeColumnsMetaclass, cls).new, you have to be more careful about the order you subclass things that you should have to be.

Luckily the fix is trivial :-)

@bradleyayers
Copy link
Collaborator

Thanks for this, I merged in your patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants