Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a limitation of using dataset for different algs? #5

Closed
mrbeann opened this issue Oct 21, 2021 · 8 comments
Closed

Is there a limitation of using dataset for different algs? #5

mrbeann opened this issue Oct 21, 2021 · 8 comments

Comments

@mrbeann
Copy link

mrbeann commented Oct 21, 2021

Firstly, thank you for building this awesome benchmark. While I try the example with different datasets (e.g., I try astra with youtube dataset), I got some errors like this,

    loss = cross_entropy_with_probs(predict_l, batch['labels'].to(device))
KeyError: 'labels'

Can this be fixed?

@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 21, 2021

Hey did you use the new youtube dataset in the classification folder in this link?

The youtube dataset is updated, but the dataset.zip hasn't. I could run astra with youtube dataset

@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 21, 2021

Oh did you use Bert backbone?

@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 21, 2021

@mrbeann hey, if you're using BERT backbone for astra, then there's a bug and I just fixed it. Could you update to the latest commit and see if it works for you?

@mrbeann
Copy link
Author

mrbeann commented Oct 21, 2021

Yeah, I use BERT. And I just pull the newest version. It seems some errors are fixed but it still raises errors.

    weak_labels = batch['weak_labels'].long().to(device)
KeyError: 'weak_labels'

@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 21, 2021

@mrbeann sry, one minute!

@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 21, 2021

@mrbeann should work now!

@mrbeann
Copy link
Author

mrbeann commented Oct 22, 2021

Thanks for the quick fix, it works. And, it will be great if this repo can include some benchmark results of different algorithms.

@mrbeann mrbeann closed this as completed Oct 22, 2021
@mrbeann mrbeann reopened this Oct 22, 2021
@JieyuZ2
Copy link
Owner

JieyuZ2 commented Oct 22, 2021

hey @mrbeann for benchmark results plz check out our NeurIPS paper! For newly-added methods, the results should be released in our future paper!

@JieyuZ2 JieyuZ2 closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants