Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark models show different l2p,l2q from the paper #53

Closed
holyhao opened this issue Mar 16, 2022 · 4 comments
Closed

Benchmark models show different l2p,l2q from the paper #53

holyhao opened this issue Mar 16, 2022 · 4 comments

Comments

@holyhao
Copy link

holyhao commented Mar 16, 2022

I download the benchmark models from the site, and test it on lanfan dataset. But the l2p and l2q are diffrent from the paper. I wonder if something wrong with my setting. Or, the benchmark models are not the best setting trained models.

@jihoonerd
Copy link
Owner

jihoonerd commented Mar 16, 2022

@holyhao For 40, 60, 80, 120 frame settings, you can reproduce it just with the test_benchmark.py. For 30-frame setting, you should manually set test_window to 65 since test_benchmark.py is primarily targeted for longer frames.

I confirmed the exact same numbers from the paper with the setting above with the weights I uploaded. :)

@jihoonerd
Copy link
Owner

I will leave comment about the test_window part.

@holyhao
Copy link
Author

holyhao commented Mar 17, 2022

@jihoonerd Thansk for your reply. I follow the test_window as 65 for 30frames test and it shows the same results as the paper. But, there is some confusion for me . How can test_window infulence the results so much and the test_window only infulence the test data partition.

@jihoonerd
Copy link
Owner

jihoonerd commented Mar 17, 2022

@holyhao I also had same concern that you just mentioned. I agree with your opinion that it should only affect the how the data is prepared, not the end performance. My naive guess is that test_window may be related to human motion in terms of periodicity. I remember the effect of window length is reduced in longer horizon settings. In the experiment, I just followed the offset and window settings suggested from the original paper and other implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants