Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the "lift_ratio" in the file config? #2

Closed
qwqwq1445 opened this issue Apr 13, 2024 · 4 comments
Closed

what is the "lift_ratio" in the file config? #2

qwqwq1445 opened this issue Apr 13, 2024 · 4 comments

Comments

@qwqwq1445
Copy link

as title.

@qwqwq1445
Copy link
Author

In the peft_wrapper.py, some code of the function "prepare_inputs_for_generation_peft" confuses me. Can you please tell me what does these lines of code want to do?
image
Especially codes in the else block. I think it will not be conducted in any case. Am I right?

@qwqwq1445
Copy link
Author

I have a question about the aggregation process of MAC. During inference, MAC aggregates document information into the compressed question prompts, and I wonder, have you done any experiments that only use the compressed question prompts to form the extra p-tuningv2 model parameters without any documents? I would like to know your experiment results in this setting because I tried to do so and it seems that the documents provide limited information to the compressed question prompts.

@jihoontack
Copy link
Owner

Hi, thank you for your interest in our paper,

I did not see the issue. lift_ratio is the backpropagation dropout ratio that is used in the paper.

For your question, during development, we tested on distilgpt2, and it worked well with the documents. (by only using the question it show some degradation, but not that much as the overall score is low for this model size).

I am on a holiday for quite a while, and happy to help any issue afterwards! I usually don't see the github so feel free to reach out using my email :) jihoontack@gmail.com

Best,
Jihoon

@qwqwq1445
Copy link
Author

In the peft_wrapper.py, some code of the function "prepare_inputs_for_generation_peft" confuses me. Can you please tell me what does these lines of code want to do? image Especially codes in the else block. I think it will not be conducted in any case. Am I right?

Still confused now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants