-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"make install" only install libebur128 #20
Comments
With this pull request #8
|
Looks like that PR is out of date, and it didn't solve plugin search. (And installed static libraries no one needs.) Plugins should be installed into a subdirectory of --- scanner/inputaudio/CMakeLists.txt.orig 2019-06-14 18:58:09 UTC
+++ scanner/inputaudio/CMakeLists.txt
@@ -20,5 +20,8 @@ if(GMODULE20_FOUND AND NOT DISABLE_GLIB20)
add_library(input input)
+ set_property(TARGET input APPEND PROPERTY
+ COMPILE_DEFINITIONS "INPUT_PREFIX=\"${CMAKE_INSTALL_PREFIX}\"")
+
target_link_libraries(input ${GMODULE20_LIBRARIES})
endif()
--- scanner/inputaudio/input.c.orig 2018-07-01 10:28:47 UTC
+++ scanner/inputaudio/input.c
@@ -21,6 +21,7 @@ static const char* plugin_search_dirs[] = {
"r128",
"",
NULL, /* = g_path_get_dirname(av0); */
+ INPUT_PREFIX "/lib/loudness",
NULL
}; --- scanner/CMakeLists.txt.orig 2018-07-01 10:28:47 UTC
+++ scanner/CMakeLists.txt
@@ -47,6 +47,7 @@ if(GLIB20_FOUND AND GTHREAD20_FOUND AND NOT DISABLE_GL
target_link_libraries(loudness
scanner-lib filetree input
${GLIB20_LIBRARIES} ${GTHREAD20_LIBRARIES})
+ install(TARGETS loudness DESTINATION bin)
--- scanner/inputaudio/ffmpeg/CMakeLists.txt.orig 2019-06-14 18:36:05 UTC
+++ scanner/inputaudio/ffmpeg/CMakeLists.txt
@@ -47,4 +47,6 @@ if(LIBAVFORMAT_FOUND AND GMODULE20_FOUND AND
set_target_properties(input_ffmpeg PROPERTIES
LINK_FLAGS ${INPUT_FFMPEG_LDFLAGS})
endif()
+
+ install(TARGETS input_ffmpeg DESTINATION lib/loudness)
endif()
--- scanner/inputaudio/mpcdec/CMakeLists.txt.orig 2019-06-14 18:36:31 UTC
+++ scanner/inputaudio/mpcdec/CMakeLists.txt
@@ -27,4 +27,6 @@ if(GMODULE20_FOUND AND MPCDEC_FOUND AND
set_target_properties(input_musepack PROPERTIES
COMPILE_FLAGS ${INPUT_MPCDEC_CFLAGS}
LINK_FLAGS ${INPUT_MPCDEC_LDFLAGS})
+
+ install(TARGETS input_musepack DESTINATION lib/loudness)
endif()
--- scanner/inputaudio/mpg123/CMakeLists.txt.orig 2019-06-14 18:35:59 UTC
+++ scanner/inputaudio/mpg123/CMakeLists.txt
@@ -27,4 +27,6 @@ if(GMODULE20_FOUND AND MPG123_FOUND AND
set_target_properties(input_mpg123 PROPERTIES
COMPILE_FLAGS ${INPUT_MPG123_CFLAGS}
LINK_FLAGS ${INPUT_MPG123_LDFLAGS})
+
+ install(TARGETS input_mpg123 DESTINATION lib/loudness)
endif()
--- scanner/inputaudio/sndfile/CMakeLists.txt.orig 2019-06-14 18:37:36 UTC
+++ scanner/inputaudio/sndfile/CMakeLists.txt
@@ -32,4 +32,6 @@ if(GMODULE20_FOUND AND SNDFILE_FOUND AND
set_target_properties(input_sndfile PROPERTIES
LINK_FLAGS ${INPUT_SNDFILE_LDFLAGS})
endif()
+
+ install(TARGETS input_sndfile DESTINATION lib/loudness)
endif() (doesn't include gstreamer because I don't want anything to use the ancient gstreamer 0.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On my gentoo amd64 system, the build succed, but "make install only install libebur128:
I made a live ebuild in order to incorporate it with portage. The installation phase is:
We can see that the plugins and the software is build, but they are not installed.
Also, the QA notice may be of interest.
Best,
Dominique
The text was updated successfully, but these errors were encountered: