Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status code is 200 instead of 404 #351

Closed
1 task done
nerg4l opened this issue Feb 11, 2023 · 2 comments
Closed
1 task done

Status code is 200 instead of 404 #351

nerg4l opened this issue Feb 11, 2023 · 2 comments
Labels
bug needs triage

Comments

@nerg4l
Copy link
Collaborator

nerg4l commented Feb 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The response code for a not found resource (anime/manga) randomly switches between 200 and 404.

Expected Behavior

The status code should be consistent for a not found resource.

Steps To Reproduce

  1. Go to https://api.jikan.moe/v4/anime/2 or https://api.jikan.moe/v4/manga/5
  2. Refresh the page a few times

Environment

- Client: Guzzle

Anything else?

Client is generated with https://openapi-generator.tech/ which only handles response code errors but not the status in the returned body.
@aetherstrata aetherstrata mentioned this issue Mar 22, 2023
Closed
@irfan-dahir
Copy link
Contributor

This should be resolved now, I think.

@irfan-dahir
Copy link
Contributor

Yep, resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerg4l @irfan-dahir