Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UG][Delete Supplier Command] Index information #18

Open
Jillzyt opened this issue Nov 13, 2020 · 1 comment
Open

[UG][Delete Supplier Command] Index information #18

Jillzyt opened this issue Nov 13, 2020 · 1 comment

Comments

@Jillzyt
Copy link
Owner

Jillzyt commented Nov 13, 2020

Index message may be clearer to state from 1 to the length of the list as zero may seem valid to some users.
image.png

@Jillzyt Jillzyt changed the title [UG][Delete Command] Index information [UG][Delete Supplier Command] Index information Nov 13, 2020
@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

Tester screenshot is incomplete, "from 1 to the length of the list" is included in the second half of the delete command in the UG.

In the case where users do not know that positive integer does not include zero, index zero is not used in our GUI and appropriate error message will be shown to users whenever there is an attempt to use index zero.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: The team was unclear on where to find the from 1 to the length of the list is included in the second half of the delete command in the UG.

Tried to ctrl+F to find the text. However, could not find such.

image.png

The screenshot below is the extended picture of delete section.
image.png


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: The bug is not only cosmetic and affects the usage of the application at rare occasions as the user may expect a different output.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants