Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'rain' processing should occur if old status is 'lost connection' #114

Open
diceit-git opened this issue Dec 30, 2023 · 2 comments
Open

Comments

@diceit-git
Copy link

diceit-git commented Dec 30, 2023

After reconnecting the raw data look like:

2023-11-25 12:56:20,30,61,9.5,83,1,942.5,0.7,1.4,14,243.6,0,7943.2,0
2023-11-25 13:00:20,4,61,9.2,,,942.7,,,,0,64,,
...
2023-11-25 14:56:33,30,64,8.8,,,942.2,,,,0,64,,
2023-11-25 15:26:28,30,64,8.8,86,1.1,942.3,0.7,1.4,4,243.6,0,,
2023-11-25 15:56:02,30,65,9,87,1,942.3,0.3,0.7,8,243.6,0,,

process.py calculates the rain delta without recognizing that the WSStatus of previous value is "not connected", so you get a peek in rain values of, in this case, 243.6mm, which is incorrect.

The WSStatus should be recognized and rain value only be calculated if both readings are valid

@jim-easterbrook
Copy link
Owner

jim-easterbrook commented Dec 30, 2023

That makes sense, but maybe with a time comparison so that short bursts of lost connection don't cause too much of a problem.

I get occasional lost connection and have never noticed this problem though. But my logging interval is the recommended 5 minutes rather than the 30 minutes you appear to be using.

@diceit-git
Copy link
Author

Hi Jim,
maybe it's working 'accidentally' with 5 min, because the value exceeds the delay*5 border, if I look at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants