Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for commented code #451

Closed
TCABJ opened this issue Jan 30, 2020 · 0 comments · Fixed by #722
Closed

False positive for commented code #451

TCABJ opened this issue Jan 30, 2020 · 0 comments · Fixed by #722
Labels
bug an unexpected problem or unintended behavior
Milestone
3.0.0

Comments

@TCABJ
Copy link

TCABJ commented Jan 30, 2020

It's possible to generate a false positive for commented code by creating an object with a name containing two hashtags separated by any alpha-numeric character.

Linted code:

c("#a#" = 1)

Message:

.../test.R style: Commented code should be removed.
c("#a#" = 1)
    ^~~~~~~~

This should not be flagged as commented code.
@russHyde russHyde added the bug an unexpected problem or unintended behavior label Mar 30, 2020
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jan 31, 2021
AshesITR added a commit that referenced this issue Jan 31, 2021
@AshesITR
fixes #451
84cdc87
@AshesITR AshesITR mentioned this issue Jan 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Skip commented_code_linter if actual parsed content was matched. r-lib/lintr
3 participants
@MichaelChirico @russHyde @TCABJ