Read namespace files in packages that aren't in directories with their name #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please delete the .DS file |
|
Oops, sorry about that. Should be gone now |
AshesITR
reviewed
Jul 24, 2021
R/namespace.R
Outdated
| @@ -2,7 +2,7 @@ | |||
| namespace_imports <- function(path = find_package()) { | |||
| imports <- tryCatch({ | |||
| pkg_name <- suppressWarnings(pkg_name(path)) | |||
| data <- parseNamespaceFile(package = pkg_name, package.lib = file.path(path, "..")) | |||
| data <- parseNamespaceFile(package = "", package.lib = path) | |||
There was a problem hiding this comment.
Internally this will call file.path with a zero-length string, using path//NAMESPACE as the path instead of path/NAMESPACE. Using package = basename(path) would be more robust.
AshesITR
reviewed
Jul 24, 2021
AshesITR
approved these changes
Aug 20, 2021
|
Is there anything else I should do for this PR? |
|
Sorry, I wanted to manually test this PR before merging to master, but forgot to do the merge. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some packages, the directory they are housed in is not simply their name (e.g. Arrow's r package is housed under
arrow/r)This change fixes that (as well as adds a test that it is fixed)