Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Purpose CC codes are off #22

Closed
johnkolen opened this issue Apr 29, 2022 · 2 comments
Closed

General Purpose CC codes are off #22

johnkolen opened this issue Apr 29, 2022 · 2 comments
Assignees
@jimm

Comments

@johnkolen
Copy link

It looks like the CC codes in consts.rb are off:

  CC_HOLD_2 = 69
  CC_GEN_PURPOSE_5 = 50
  CC_GEN_PURPOSE_6 = 51
  CC_GEN_PURPOSE_7 = 52
  CC_GEN_PURPOSE_8 = 53
  CC_TREMELO_DEPTH = 92

The general purpose CCs 5 through 10 should start at 70, not 50.
@jimm
Copy link
Owner

jimm commented Apr 30, 2022

@johnkolen thank you for catching this! I think the values should actually be 0x50...0x53 which is 80..83 in decimal. See "Table III: Controller Numbers" in the MIDI detailed spec doc.

I should update the whole list, but I'll fix these right away. Thanks again!

@jimm jimm self-assigned this Apr 30, 2022
@jimm
Copy link
Owner

jimm commented Apr 30, 2022

Fixed in version 3.0.1.

@jimm jimm closed this as completed Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimm jimm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimm @johnkolen