Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard JS formatting #24

Closed
ylon opened this issue Mar 15, 2018 · 4 comments
Closed

Standard JS formatting #24

ylon opened this issue Mar 15, 2018 · 4 comments

Comments

@ylon
Copy link
Contributor

ylon commented Mar 15, 2018

Hello,
would you be ok to use standardjs formatting, or tell what kind of formatting you're using.
because now seems difficult to merge.
if you can want I can make a PR.
regards

@JimmyLaurent
Copy link
Owner

Hi,
You're right, it's missing.
I like to use prettier to format my code.

This is my config:

"prettier": {
    "singleQuote": true,
    "trailingComma": "none",
    "parser": "flow",
    "semi": true,
    "tabWidth": 2
  }

I'll take care of adding it to the project. Thanks.

@ylon
Copy link
Contributor Author

ylon commented Mar 21, 2018

Thanks,
I have installed prettier-atom.
the result i got is different than yours. expanding more, respecting max line length,
cf: https://github.com/prettier/prettier#intro

@JimmyLaurent
Copy link
Owner

Yeah, I plan to use prettier on "torrent-search-api", but I didn't do it yet.
So it's normal if it's different. I'll do it when I have some time.

@JimmyLaurent
Copy link
Owner

@ylon : I made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants