Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert_block deprecated in minitest-2.12.0 and later #12

Closed
randycoulman opened this issue Jan 11, 2013 · 3 comments
Closed

assert_block deprecated in minitest-2.12.0 and later #12

randycoulman opened this issue Jan 11, 2013 · 3 comments

Comments

@randycoulman
Copy link

In MiniTest 2.12.0, assert_block was deprecated. Any expectation failure results in a deprecation warning coming from the super send at test_unit_integration.rb:53.

I had a brief look at how to fix it, but I wasn't sure of the best way to proceed. It would be possible to replace the implementation of TestFrameworkAdapter#assert_block with something like this:

assert(yield, message)

But I'm not sure if that provides the desired error message or not.

I'd be happy to work on a pull request given a little direction of the best approach to take.

@randycoulman
Copy link
Author

Update: assert_block was removed in minitest-4.6.0.

@jimweirich
Copy link
Owner

Thanks. It is fixed on HEAD. I just need a to find a time to put together a release.

@randycoulman
Copy link
Author

Awesome, thanks! I should have looked at the commit history before updating. Sorry 'bout that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants