Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Documents in a Database #83

Closed
myntoralex opened this issue Dec 22, 2021 · 5 comments
Closed

Persist Documents in a Database #83

myntoralex opened this issue Dec 22, 2021 · 5 comments

Comments

@myntoralex
Copy link

Currently, only the HNSWPostgresIndexer supports persistence of Documents. Could we add the PQLiteIndexer some database persistence, not necessarily Postgres, but any database provider?

@JoanFM
Copy link
Member

JoanFM commented Dec 22, 2021

I believe the easiest way could be to support pointing to an external SQLite?

@numb3r3
Copy link
Member

numb3r3 commented Dec 23, 2021

@myntoralex Currently, persistence is already supported via local-disk kv-store lmdb (the data is located at workspace folder defaultly). Is this local-disk persistence is what you expected? Or do you want to have external/remote data persistence supporting?

@numb3r3
Copy link
Member

numb3r3 commented Dec 23, 2021

I see, I think you want external persistence supports actually. And there maybe two branches we can proceed:

  1. supporting external database e.g., ElasticeSearch, Postgres etc.,
  2. supporting object storage e.g., AWS S3, Google GCS

It would be great to get your preference, and that will help us to determine the priority of new features.

@myntoralex
Copy link
Author

I would definitely prefer option 1, since change data capture from one database table or collection ought to be reflected in a similar data view. Thanks!

@cristianmtr
Copy link
Contributor

cristianmtr commented Jan 3, 2022

Hey @myntoralex

Could you elaborate on your use case? What are you trying to do exactly with the external storage? It might help clarify the direction to go

@numb3r3 numb3r3 closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants