feat: change pydantic model optional id (#77)

docarray · Jan 24, 2022 · 06cd577 · 06cd577
1 parent 7a868d3
commit 06cd577
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/docarray/document/pydantic_model.py b/docarray/document/pydantic_model.py
@@ -28,7 +28,7 @@ class _NamedScore(BaseModel):
 
 
 class PydanticDocument(BaseModel):
-    id: str
+    id: Optional[str]
     parent_id: Optional[str]
     granularity: Optional[int]
     adjacency: Optional[int]

diff --git a/tests/unit/test_pydantic.py b/tests/unit/test_pydantic.py
@@ -166,3 +166,7 @@ def test_to_from_with_blob(protocol, to_fn, blob):
     assert d.blob == r_d.blob
     if d.blob:
         assert isinstance(r_d.blob, bytes)
+
+
+def test_pydantic_not_id():
+    _ = PydanticDocument()