Skip to content

Commit

Permalink
test: try to get jac tests back up (#1485)
Browse files Browse the repository at this point in the history
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Co-authored-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
  • Loading branch information
JoanFM and Jackmin801 committed May 4, 2023
1 parent e37a59e commit 2d426df
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
10 changes: 6 additions & 4 deletions docarray/store/jac.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ def list(namespace: str = '', show_table: bool = False) -> List[str]:
from rich.table import Table

resp = HubbleClient(jsonify=True).list_artifacts(
filter={'type': 'documentArray'}, sort={'createdAt': 1}
filter={'type': 'documentArray'},
sort={'createdAt': 1},
pageSize=10000,
)

table = Table(
Expand Down Expand Up @@ -267,10 +269,10 @@ def push_stream(
# But it must be done this way for now because Hubble expects to know the length of the DocList
# before it starts receiving the documents
first_doc = next(docs)
docs = DocList[first_doc.__class__]([first_doc]) # type: ignore
_docs = DocList[first_doc.__class__]([first_doc]) # type: ignore
for doc in docs:
docs.append(doc)
return cls.push(docs, name, public, show_progress, branding)
_docs.append(doc)
return cls.push(_docs, name, public, show_progress, branding)

@staticmethod
@hubble.login_required
Expand Down
8 changes: 1 addition & 7 deletions tests/integrations/store/test_jac.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
TOLERANCE_RATIO = 0.5 # Percentage of difference allowed in stream vs non-stream test
RANDOM: str = uuid.uuid4().hex[:8]

pytestmark = [pytest.mark.skip]


@pytest.fixture(scope='session', autouse=True)
def testing_namespace_cleanup():
Expand All @@ -34,7 +32,7 @@ def testing_namespace_cleanup():
)
)
for da_name in da_names:
JACDocStore.delete(f'jac://{da_name}')
JACDocStore.delete(f'{da_name}')


@pytest.mark.slow
Expand Down Expand Up @@ -68,7 +66,6 @@ def test_pushpull_correct(capsys):
assert len(captured.err) == 0, 'No error should be printed when show_progress=False'


@pytest.mark.skip(reason='time out')
@pytest.mark.slow
@pytest.mark.internet
def test_pushpull_stream_correct(capsys):
Expand Down Expand Up @@ -100,7 +97,6 @@ def test_pushpull_stream_correct(capsys):
assert len(captured.err) == 0, 'No error should be printed when show_progress=False'


@pytest.mark.skip(reason='time out')
@pytest.mark.slow
@pytest.mark.internet
def test_pull_stream_vs_pull_full():
Expand Down Expand Up @@ -157,7 +153,6 @@ def get_total_full(url: str):
), 'Full pull memory usage should be dependent on the size of the data'


@pytest.mark.skip(reason='The CI account might be broken')
@pytest.mark.slow
@pytest.mark.internet
def test_list_and_delete():
Expand Down Expand Up @@ -214,7 +209,6 @@ def test_list_and_delete():
), 'Deleting a non-existent DA should return False'


@pytest.mark.skip(reason='time out')
@pytest.mark.slow
@pytest.mark.internet
def test_concurrent_push_pull():
Expand Down

0 comments on commit 2d426df

Please sign in to comment.