fix(array): remove the support of singleton boolean index (#31)

docarray · Jan 11, 2022 · 3a906db · 3a906db
1 parent beeb322
commit 3a906db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/docarray/array/document.py b/docarray/array/document.py
@@ -205,7 +205,7 @@ def __setitem__(
         index: 'DocumentArrayIndexType',
         value: Union['Document', Sequence['Document']],
     ):
-        if isinstance(index, (int, np.generic)):
+        if isinstance(index, (int, np.generic)) and not isinstance(index, bool):
             index = int(index)
             self._data[index] = value
             self._id2offset[value.id] = index
@@ -289,7 +289,7 @@ def __setitem__(
             raise IndexError(f'Unsupported index type {typename(index)}: {index}')
 
     def __delitem__(self, index: 'DocumentArrayIndexType'):
-        if isinstance(index, (int, np.generic)):
+        if isinstance(index, (int, np.generic)) and not isinstance(index, bool):
             index = int(index)
             self._id2offset.pop(self._data[index].id)
             del self._data[index]

diff --git a/tests/unit/array/test_advance_indexing.py b/tests/unit/array/test_advance_indexing.py
@@ -229,5 +229,11 @@ def test_single_boolean_and_padding():
     with pytest.raises(IndexError):
         da[True]
 
+    with pytest.raises(IndexError):
+        da[True] = Document()
+
+    with pytest.raises(IndexError):
+        del da[True]
+
     assert len(da[True, False]) == 1
     assert len(da[False, False]) == 0