Skip to content

Commit

Permalink
fix(store): change default serialization protocol to pickle (#97)
Browse files Browse the repository at this point in the history
  • Loading branch information
hanxiao committed Feb 4, 2022
1 parent f3f3de4 commit a72a18d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docarray/array/storage/sqlite/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _sanitize_table_name(table_name: str) -> str:
class SqliteConfig:
connection: Optional[Union[str, 'sqlite3.Connection']] = None
table_name: Optional[str] = None
serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'})
serialize_config: Dict = field(default_factory=dict)
conn_config: Dict = field(default_factory=dict)
journal_mode: str = 'DELETE'
synchronous: str = 'OFF'
Expand Down
2 changes: 1 addition & 1 deletion docarray/array/storage/weaviate/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class WeaviateConfig:
client: Optional[Union[str, weaviate.Client]] = None
n_dim: Optional[int] = None
name: Optional[str] = None
serialize_config: Dict = field(default_factory=lambda: {'protocol': 'protobuf'})
serialize_config: Dict = field(default_factory=dict)


class BackendMixin(BaseBackendMixin):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/array/mixins/test_embed.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
)


@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch', 'paddle'])
@pytest.mark.parametrize('framework', ['onnx', 'keras', 'pytorch'])
@pytest.mark.parametrize(
'da', [DocumentArray, DocumentArraySqlite, DocumentArrayWeaviate]
)
Expand Down

0 comments on commit a72a18d

Please sign in to comment.