Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(normalizer): check manifest cfg in both config.yml and manifest.yml #52

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

Andrei997
Copy link
Member

@Andrei997 Andrei997 commented Aug 29, 2022

Will first check if

metas:
  name: SOME_NAME

exists in the config.yml. If true, then skip the manifest.yml.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #52 (4b2f6d0) into main (e257e30) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   86.35%   86.53%   +0.18%     
==========================================
  Files           9        9              
  Lines         513      520       +7     
==========================================
+ Hits          443      450       +7     
  Misses         70       70              
Impacted Files Coverage Δ
generator/core.py 91.26% <0.00%> (-0.16%) ⬇️
normalizer/docker/parser.py 93.93% <0.00%> (+1.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Andrei997 Andrei997 marked this pull request as ready for review August 31, 2022 08:18
Copy link
Member

@mapleeit mapleeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapleeit mapleeit merged commit e330b46 into main Sep 1, 2022
@mapleeit mapleeit deleted the refactor-manifest-config branch September 1, 2022 02:57
@nan-wang
Copy link
Member

nan-wang commented Sep 1, 2022

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mapleeit
Copy link
Member

mapleeit commented Sep 1, 2022

Nice work! @Andrei997

I already reviewed the PR and merged it. It will release a new version 0.9.0. And we need to use this version explictly in Hubble's repo.

Then it will be deployed to the production along with Hubble's deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants