Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress bar should show real percentage progress of training #116

Closed
hanxiao opened this issue Oct 12, 2021 · 2 comments
Closed

progress bar should show real percentage progress of training #116

hanxiao opened this issue Oct 12, 2021 · 2 comments
Labels
area/tuner This issue/PR affects the tuner
Milestone
Release 0.1

Comments

@hanxiao
Copy link
Member

hanxiao commented Oct 12, 2021

implementation could like:

  • for the 1st epoch, sometimes we don't know the length, we keep a counter and store the total length of the iteratable
  • and then from 2nd epoch, we can show the percentage.
@hanxiao hanxiao added the area/tuner This issue/PR affects the tuner label Oct 12, 2021
@maximilianwerk maximilianwerk added this to the Release 0.1 milestone Oct 14, 2021
@hanxiao
Copy link
Member Author

hanxiao commented Oct 14, 2021

i think it is a upstream problem of jina, jina's progressbar does not have a total_length attribute, hence no way to compute percentage, will see what can be done there

@hanxiao
Copy link
Member Author

hanxiao commented Oct 15, 2021

upstream is ready

jina-ai/jina#3688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tuner This issue/PR affects the tuner
Projects
None yet
Milestone
Release 0.1
Development

No branches or pull requests
2 participants
@hanxiao @maximilianwerk