Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Refactor matches elements to separate vue components #92

Closed
Roshanjossey opened this issue Oct 5, 2021 · 0 comments · Fixed by #101
Closed

UI: Refactor matches elements to separate vue components #92

Roshanjossey opened this issue Oct 5, 2021 · 0 comments · Fixed by #101
Assignees
@Roshanjossey
Labels
type/maintenance This issue is not a bug or a feature_request.

Comments

@Roshanjossey
Copy link
Contributor

Currently, we have image and text matches tables.

If we want to extend this to more mimetypes, we should make sure that it doesn't get hard to maintain the HTML file as a whole. Refactoring out components for them could be a good way to simplify it.
@CatStark CatStark added the type/maintenance This issue is not a bug or a feature_request. label Oct 6, 2021
@Roshanjossey Roshanjossey self-assigned this Oct 6, 2021
@Roshanjossey Roshanjossey linked a pull request Oct 7, 2021 that will close this issue
refactor(labeler UI): js file into components #101
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roshanjossey Roshanjossey

Labels
type/maintenance This issue is not a bug or a feature_request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(labeler UI): js file into components jina-ai/finetuner
2 participants
@CatStark @Roshanjossey