Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow config num_items_per_class #614

Merged
merged 6 commits into from Nov 24, 2022
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Nov 24, 2022

Some examples need us to control num_items_per_class to be sampled into a batch. If it is not set, will be by default set as 4 in runner. In finetuner-core, the value will be guessed automatically.

Also removed callbacks from the api doc to avoid duplication.


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu marked this pull request as ready for review November 24, 2022 11:58
finetuner/finetuner.py Outdated Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
finetuner/__init__.py Outdated Show resolved Hide resolved
@gmastrapas
Copy link
Member

Also add a line in CHANGELOG that says that callback is removed from api doc

@github-actions
Copy link

📝 Docs are deployed on https://ft-feat-num-item-per-class--jina-docs.netlify.app 🎉

Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwanglzu bwanglzu merged commit e3fb036 into main Nov 24, 2022
@bwanglzu bwanglzu deleted the feat-num-item-per-class branch November 24, 2022 13:28
@bwanglzu bwanglzu restored the feat-num-item-per-class branch December 13, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants