Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CLI Commands #98

Open
EvanTsiatsios opened this issue Oct 28, 2019 · 6 comments
Open

Support for CLI Commands #98

EvanTsiatsios opened this issue Oct 28, 2019 · 6 comments
Labels

Comments

@EvanTsiatsios
Copy link

Is it possible to support (or expose via some path or variable) the dotnet cli? I am trying to use some testing and code quality tools (specifically dotnet test with code coverage and sonarqube scan) during the test setup phase on heroku and naturally the .net cli is not recognized. Is there a way I could source this via a bash script to create my process?

@jincod
Copy link
Owner

jincod commented Oct 30, 2019

Hi @EvanTsiatsios,

Have you seen this PR?

@EvanTsiatsios
Copy link
Author

Hi @jincod sorry for the very late reply. I did in fact take a look at the PR and it looks very close to what I want to achieve (Testpack support is 100% necessary and paves the way to CLI support imho).

Are you planning on merging/finishing any of these changes to master or are you waiting for a PR to be finished?

As I have perceived the conversation so far the problem is code duplication more so than the ability to execute the actual code?

@jincod
Copy link
Owner

jincod commented Jan 16, 2020

Hi @EvanTsiatsios,

Testpack PR was merged to https://github.com/jincod/dotnetcore-buildpack#jbowtie-add-testpack-api. Could you check it please?

I'll merge it if everything is ok

@EvanTsiatsios
Copy link
Author

@jincod I'll take a look asap!

@EvanTsiatsios
Copy link
Author

@jincod Good afternoon! Sorry for the delayed response, I was a bit under the weather. I have review your changes and I tried running some tests but sadly to no success. Could you tell me If I am doing something wrong?

I added your buildpack and then in the app.json I added it to the testing environment too.
"test": {
"scripts": {
"test-setup":"dotnet test",
"test": "dotnet test"
},

The tests fail saying: "bash: dotnet: command not found"

@EvanTsiatsios
Copy link
Author

Hey @jincod , I had some time to examine the PR some more and run some tests. I don't think it works exactly how I envisioned it.

I took the liberty of making the changes myself and adding support for the following:

*tests
*dotnet tools
*Exposure of the runtime and CLI from the app.json so people can run custom test-setup and test scripts utilizing all of the dotnet CLI capabilities.

Im currently in the process of cleaning up the code and finalizing the changes, so you can expect a PR from me around Monday/Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants