-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CLI Commands #98
Comments
Hi @EvanTsiatsios, Have you seen this PR? |
Hi @jincod sorry for the very late reply. I did in fact take a look at the PR and it looks very close to what I want to achieve (Testpack support is 100% necessary and paves the way to CLI support imho). Are you planning on merging/finishing any of these changes to master or are you waiting for a PR to be finished? As I have perceived the conversation so far the problem is code duplication more so than the ability to execute the actual code? |
Hi @EvanTsiatsios, Testpack PR was merged to I'll merge it if everything is ok |
@jincod I'll take a look asap! |
@jincod Good afternoon! Sorry for the delayed response, I was a bit under the weather. I have review your changes and I tried running some tests but sadly to no success. Could you tell me If I am doing something wrong? I added your buildpack and then in the app.json I added it to the testing environment too. The tests fail saying: "bash: dotnet: command not found" |
Hey @jincod , I had some time to examine the PR some more and run some tests. I don't think it works exactly how I envisioned it. I took the liberty of making the changes myself and adding support for the following: *tests Im currently in the process of cleaning up the code and finalizing the changes, so you can expect a PR from me around Monday/Tuesday. |
Is it possible to support (or expose via some path or variable) the dotnet cli? I am trying to use some testing and code quality tools (specifically dotnet test with code coverage and sonarqube scan) during the test setup phase on heroku and naturally the .net cli is not recognized. Is there a way I could source this via a bash script to create my process?
The text was updated successfully, but these errors were encountered: