Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about opt.crop_size #1

Open
ShineLX opened this issue Aug 19, 2021 · 2 comments
Open

A question about opt.crop_size #1

ShineLX opened this issue Aug 19, 2021 · 2 comments

Comments

@ShineLX
Copy link

ShineLX commented Aug 19, 2021

Thanks for sharing the source codes.
When opt.arb_sample is set to be 1 (flexible sampling), the opt.crop_size is 0. However, when opt.arb_sample is set to be 0 (fixed sampling), the opt.crop_size is opt.psv_range * (opt.angular_out - 1). I did not find the reason for these two different settings in your paper. Can you please help me with it?

@jingjin25
Copy link
Owner

@ShineLX

Hi.

As PSV has zero boundaries which will make the training unstable, we used non-zero crop_size for the fixed sampling. This influence is not obvious when arb_sample, so we did not apply the cropping.

@ShineLX
Copy link
Author

ShineLX commented Sep 10, 2021

@jingjin25
I see. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants