Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce results #14

Closed
laos1984 opened this issue Jul 23, 2021 · 2 comments
Closed

Reproduce results #14

laos1984 opened this issue Jul 23, 2021 · 2 comments

Comments

@laos1984
Copy link

Hi Jingtao,

I try to reproduce the results showing in the README. The models are downloaded from google drive.
For the transformers version, preprocessing is 2.8.0 and for inference is 4.8.2.

I ran the following commands:
python ./star/inference.py --data_type passage --max_doc_length 256 --mode dev
python ./msmarco_eval.py ./data/passage/preprocess/dev-qrel.tsv ./data/passage/evaluate/star/dev.rank.tsv

And I got the following results:
Eval Started
#####################
MRR @10: 0.010382669304589082
QueriesRanked: 6980
#####################

Could you help to figure out what I did wrong? Thanks!

@jingtaozhan
Copy link
Owner

I'm not sure why this happens.
Firstly, maybe you can try version 3.4.0 during inference.
Secondly, I suggest checking whether the generated dev-qrel.tsv is correct. You can check it by using it to evaluate the provided STAR rank file. After downloading it, you need to convert the qids and pids to the preprocessed qoffsets and poffsets. It is a little bit tricky, but you can refer to cvt_back.py, which converts in an opposite direction (offsets to ids). Then you can run python ./msmarco_eval.py ./data/passage/preprocess/dev-qrel.tsv convt_download_dev.rank.tsv and see whether MRR@10 is 0.340.
Happy to help you :)

@jingtaozhan
Copy link
Owner

No activity. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants