Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several Changes #1

Merged
merged 3 commits into from Jul 9, 2014
Merged

Several Changes #1

merged 3 commits into from Jul 9, 2014

Conversation

cameron-martin
Copy link
Contributor

This PR contains several changes

  • Since the current rspec issues warnings about using the old-style matchers, I refactored the spec to use the expect syntax.
  • Somehow sql_parser/version was being loaded before sql_parser.treetop when running rspec, even though nowhere is sql_parser/version explicitly loaded. So I inlined the version constant in the gemspec.
  • Made keywords do a case-insensitive match. I found no better way than to use [kK] [eE] [yY] [wW] [oO] [rR] [dD], let me know if there is an easier way.

@owenthereal
Copy link
Owner

Awesome! Thanks for the contribution. I'm not actively maintaining this project anymore. So merging

owenthereal added a commit that referenced this pull request Jul 9, 2014
@owenthereal
Merge pull request #1 from cameron-martin/master
4a93f99 
Several Changes
@owenthereal owenthereal merged commit 4a93f99 into owenthereal:master Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cameron-martin @owenthereal