Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always have coverage CI pass #358

Closed
CohenArthur opened this issue Nov 14, 2021 · 0 comments · Fixed by #582
Closed

Always have coverage CI pass #358

CohenArthur opened this issue Nov 14, 2021 · 0 comments · Fixed by #582
Labels
ci Issue with continuous integration good first issue Good for newcomers

Comments

@CohenArthur
Copy link
Member

Right now, a lot of PRs are being merged despite checks failing. The checks failing are tiny coverage differences, which do not really matter. We should change the CI so that the coverage message are always posted, but the checks aren't failing. We can probably do something like

<launch codecov> || true
@CohenArthur CohenArthur added ci Issue with continuous integration good first issue Good for newcomers labels Nov 14, 2021
@tanguysegarra tanguysegarra mentioned this issue Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Issue with continuous integration good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use tarpaulin for code coverage jinko-core/jinko
1 participant
@CohenArthur