Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing check in pull-request step #549

Closed
CohenArthur opened this issue Apr 6, 2022 · 2 comments
Closed

Missing check in pull-request step #549

CohenArthur opened this issue Apr 6, 2022 · 2 comments
Assignees
@tanguysegarra
Labels
bug Something isn't working ci Issue with continuous integration priority [high] High priority issue

Comments

@CohenArthur
Copy link
Member

Currently, master is broken despite the CI passing on the pull-request. The failure occurs in the docker build part of the CI, which indicates that we should probably have one more check in the pull-request CI
@CohenArthur CohenArthur added bug Something isn't working ci Issue with continuous integration priority [high] High priority issue labels Apr 6, 2022
@tanguysegarra
Copy link
Collaborator

The specific issue we are talking about has been fixed.
Still, I agree the behaviour was really weird with a green PR but a red master, but almost look like bad luck. Unfortunately it is impossible de retrieve the logs as they are too old.
Also, I checked and all workflows are triggered both for pull requests and master.
I don't really see what check we can add, do you have something in mind?

@tanguysegarra tanguysegarra self-assigned this Sep 2, 2022
@CohenArthur
Copy link
Member Author

Not really, seems fine to me now :) Thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanguysegarra tanguysegarra

Labels
bug Something isn't working ci Issue with continuous integration priority [high] High priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanguysegarra @CohenArthur