Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sometims it will not trigger the $digest in time and then the toaster will not work correctly in time #272

Closed
newbie777 opened this issue Dec 10, 2017 · 1 comment
Closed

sometims it will not trigger the $digest in time and then the toaster will not work correctly in time #272

newbie777 opened this issue Dec 10, 2017 · 1 comment
Labels
reproduction-needed

Comments

@newbie777
Copy link

AngularJS-Toaster/toaster.js

Line 387 in 9cebfda

scope.toasters.unshift(toast);

hello , the new toaster is added to the scope.toasters . But the digest would not be triggered in time in some condition. i suggest put that into $timeout function to force the $digest
@newbie777 newbie777 changed the title sometims it will trigger the $digest and then the toaster will not work correctly in time sometims it will not trigger the $digest in time and then the toaster will not work correctly in time Dec 10, 2017
@Stabzs
Copy link
Collaborator

Stabzs commented Jan 18, 2019

This would need reproduction. Apologies for the inactivity on this issue.

@Stabzs Stabzs closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reproduction-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stabzs @newbie777