New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed sending array in AJAX request #207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 84.34% 83.38% -0.97%
==========================================
Files 11 11
Lines 345 349 +4
Branches 99 100 +1
==========================================
Hits 291 291
- Misses 21 24 +3
- Partials 33 34 +1
Continue to review full report at Codecov.
|
thanks @DzeryCZ very much for providing a lot of helps with fixing. |
Hello, first of all, thanks for the contribution, every helping hand counts! This definitely goes in the right direction, but since this issue is already on the table, I'd like to have it fixed properly, i.e.
Let me know if you're willing to put more effort into this, I might have some thoughts on how this could be implemented. Otherwise I might be able to find some time for this during this or the following week. I believe this is not a blocker, as you can always build the URL in your code until this is fixed. |
I am not good at Javascript. It's up to you. Could you fix it in your way? |
Sure, no worries :) by the way your code is really not bad, it's just that the scope of the problem is larger than you expected. |
code is from my friend @DzeryCZ . |
Well then, thanks to both of you for putting your time and effort into this! |
closes #202