Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore if there is no rvm in path #189

Closed
arashm opened this issue Oct 31, 2014 · 7 comments
Closed

Ignore if there is no rvm in path #189

arashm opened this issue Oct 31, 2014 · 7 comments

Comments

@arashm
Copy link

arashm commented Oct 31, 2014

I use rbenv and not rvm, Every time I use pre-commit it show me an error first:

which: no rvm in ($PATH...)

It does the job but the error is annoying.

@mpapis mpapis closed this as completed in 6e4b743 Oct 31, 2014
@mpapis
Copy link
Collaborator

mpapis commented Oct 31, 2014

@jish not sure if you want to do release for this?

@jish
Copy link
Owner

jish commented Oct 31, 2014

Does installing the manual hook work for you?

pre-commit install --manual

If that doesn't work, you can re-install the default hook using:

pre-commit install

Josh

On Oct 31, 2014, at 08:09, Michal Papis notifications@github.com wrote:

@jish not sure if you want to do release for this?


Reply to this email directly or view it on GitHub.

@mpapis
Copy link
Collaborator

mpapis commented Oct 31, 2014

well, haven't played with it in some time, I thought we have tests for it (on conference right now, will test tomorrow)

@jish
Copy link
Owner

jish commented Oct 31, 2014

I was just curious if using the simpler manual hook https://github.com/jish/pre-commit/blob/81c95c97bd6f01fe0db5aba24f5eef8df3af210d/templates/hooks/manual would avoid the environment detection problems.

require 'pre-commit'
PreCommit.run

@jish
Copy link
Owner

jish commented Oct 31, 2014

@mpapis I released a new version 0.21.0 with your patch.

@arashm thanks for letting us know about this issue! :) If you update the gem the error should go away.

@mpapis
Copy link
Collaborator

mpapis commented Nov 8, 2014

so finally got reason to use pre-commit => https://github.com/pre-commit-plugins/pre-commit-gpg

also tested the hook installation - it all works well for manual and default installation

@jish
Copy link
Owner

jish commented Nov 11, 2014

@mpapis cool! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants