Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon in Ubuntu dock #95

Closed
probonopd opened this issue Jul 21, 2018 · 8 comments
Closed

No icon in Ubuntu dock #95

probonopd opened this issue Jul 21, 2018 · 8 comments

Comments

@probonopd
Copy link

No icon in Ubuntu 14.04 dock (and possibly others):

icon

Probably an icon needs to be set on the BrowserWindow?

win = new BrowserWindow({
   ...
   icon: path.join(__dirname, '/icon/Icon-512x512.png')
})

Reference:

@akshitkrnagpal
Copy link
Contributor

akshitkrnagpal commented Jul 21, 2018

@probonopd
Thanks for this report but we are already doing that.

This is possibly a problem with Unity Desktop. I myself experience it during development and it seemed random. But stopped experiencing this when I upgraded to Gnome.

Also, I read somewhere that icon does not show up when we run AppImage using terminal but works if we run the application from desktop entry. Please try that too.

@probonopd
Copy link
Author

Also, I read somewhere that icon does not show up when we run AppImage using terminal but works if we run the application from desktop entry. Please try that too.

That is true only if the application does not set the window icon...

@akshitkrnagpal
Copy link
Contributor

akshitkrnagpal commented Jul 21, 2018

That is true only if the application does not set the window icon...

I guess you are right. But we already have an icon set on the window.

icon: path.resolve(basePath, './resources/icons/icon_512x512.png'),

We have tested on Ubuntu with Gnome and Fedora, so this must be problem with Unity Desktop.
I'll take a look if this is a mistake on application side again.
Thanks for reporting this.

@probonopd
Copy link
Author

I will also try out different desktops and report back here. Thanks.

@probonopd
Copy link
Author

I can confirm that it works on Xubuntu 18.04 regardless of how it was launched:

@akshitkrnagpal
Copy link
Contributor

Hey @probonopd

I can confirm that it works on Xubuntu 18.04 regardless of how it was launched:

Thanks for checking that.

I also tested this on Ubuntu 18.04 and 16.04 with Unity . I couldn't find anything and I actually was unable to reproduce this on Ubuntu 16.04 with unity (on which I experienced this earlier). So I don't think this is an issue on the application side.

Do you think we can close this? or it needs further investigation.

@probonopd
Copy link
Author

Possibly related to electron-userland/electron-builder#748 (comment)?

@akshitkrnagpal
Copy link
Contributor

Thanks @probonopd 😄
I'll update electron-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants