-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 11 WebRTC support #2000
Comments
It seems like it would be far simpler to check whether or not the relevant browser APIs are available, rather than relying on (what I'm guessing are) hardcoded User Agent strings. There's plenty of libraries out there that simplify this process. I've had success with webrtcsupport in the past. Might be worth looking in to. |
Hmm, I just tested opening https://meet.jit.si with my Safari on my iPhone 7 on iOS 11.0.2 and I still get the "Your browser does not support WebRTC" message..... Is webRTC support only available in desktop safari and not iOS 11? |
@petervnv the only support for safari currently is via the temasys plugin, so i don't think mobile will work. we're taking a look at native webrtc support for the safari versions that support it soon (though i doubt we'll be spending time on mobile safari, as we have the native app there, but @saghul or @lyubomir can confirm) |
Thanks for the update @bbaldino |
@bbaldino Would it be possible to strip out the Temasys plugin entirely, seeing as it's not required for mobile Safari any more? Is there any reason that you can't just treat mobile Safari in the same way you do any desktop browser, or even Chrome on Android, and use the built-in WebRTC APIs? |
@joshfarrant not sure if we'll be able to get rid of temasys entirely, lots of enterprises lag quite a bit on updates and are probably on old versions of ie/safari which would require the plugin. maybe someday though, it would be nice to be able to simplify things. as for treating mobile safari the same, that might be possible, but i haven't looked into what mobile safari even supports...it may or may not have the same webrtc apis implemented as in the desktop one and, even if so, unfortunately 'treating mobile browser XXX the same as desktop browser XXX' never seems to work all that well and practice and usually requires special-casing. but agree it's worth a look once we get desktop safari working. |
@bbaldino That's fair. Appreciate that enterprise users won't be particularly up-to-date and you definitely don't want to start breaking things! I've actually had a lot of success with WebRTC on mobile Safari in the past. I worked on quite a large WebRTC application (which was built for desktop browsers, as well as for Chrome on Android) which didn't require any modification at all to get it working on iOS 11. This might not be the case for every application, but it gives me hope at least! I'd be interested in testing Jitsi Meet on iOS 11 as-is (minus Temasys) to see what breaks, and how badly. Is there any chance you could point me in the right direction of where to start removing/bypassing Temasys? I've had a poke around but can't seem to find where it's referenced. |
@joshfarrant @virtuacoplenny and i are in the middle of some work right now that should make all this a lot easier...we're moving away from our own shimming and over to using adapterjs which will make supporting other browsers like safari a lot more straightforward. if you do want to poke around, there is a method in RTCBrowserUtils which tests whether or not the temasys plugin should be used. but when you turn that off for safari, you'll need to add a bunch of shimming logic to make the types/functions (getUserMedia, RTCPeerConnection) etc. set up in the way that lib-jitsi-meet expects them. i'd suggest waiting a week or two, hopefully this should be in much better shape by then. |
@bbaldino That's great to know, thanks. I'll have a bit of a poke around but won't go too deep down this rabbit hole until those changes have dropped 👍 |
Hello! I wonder if there has been any advancement on this, please? I'd love to have Safari 11 working without the plugin, just to avoid having a plug-in! |
@virtuacoplenny just did a bunch of PRs on this, though we are just doing audio-only on safari for now. but that should be available soon. |
In my case, I need to make Safari working, even by changing from VP8 to H264 and disabling simulcast. I forked the Currently, I try to completely remove VP8/VP9 from SDP but it causes even more problems. Anyone has ideas how can I work around it? Thanks |
@Kukunin i'd send an email on the list (dev@jitsi.org) and we can try and figure out your issues there. |
any update on this? |
By the way, if you are unsure of how to approach it or if it is working at all, here is a working demo that runs on iPhone Safari https://wcs5-eu.flashphoner.com/client2/examples/demo/streaming/two_way_streaming/two_way_streaming.html |
Is there any plan to make it work for Safari? Any plans? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Nice try bot, this still hasn't been fixed. 😃 |
We've got to keep an eye on these bots - This is how it starts... |
so what is the status? I see for other webrtc services like appearin, safari works except for screensharing. |
FWIW the technology preview of Safari appears to support VP8 video since preview 68. |
Just tried https://meet.jit.si on Safari Technology Preview Release 74 and video is still not supported.. This Technology Preview supports the following experimental features and they are enabled:
that's said.. What we, real users, can expect here? |
You can expect full support. But it will take a bit for us to get there, we are a tad busy these days. Don’t despair! |
We really need this to work. Thank you and appreciate all the work. |
Hello, we also need this to work on iphone safari. I was successful in editing the app_bundle_min.js to work for Android both video and audio! I was hoping to get it to work for iphone since Safari now supports webRTC. |
Seems all is shipped on Safari So we are good to go here, no blockers should be faced, all the WebRTC features are supported now do we have any updates here? ;) |
I am interested in the update as well. But also, out of curiosity, how does the Demo react native app overcome this issue on ios ? https://github.com/jitsi/jitsi-meet/tree/master/react |
Everyone: This is close to getting fixed here jitsi/lib-jitsi-meet#835 @nathando I don't understand your question. |
Sorry about that, it should never go stale now. This is now actively being worked on, so stay tuned! @jallamsetty1 please update this issue when we have progress on the Safari support front, thanks! |
Sure, will do @saghul , thanks ! |
Any progress on this? |
Hi there ! The majority of the work needed for supporting Safari in Unified plan has been completed and we are planning to merge it to the master in the next 1-2 weeks. I will update this issue when it makes it to a Jitsi Meet release. |
Amazing — congratulations. I look forward to testing it. |
@jallamsetty1 |
@jallamsetty1 is there a branch available that it can be tested from? |
By the way, the problem of my users is present in Safari 13.0.4. |
Its WIP so there is no public branch available. Are there any specific features that you are planning to test ? I can test them myself before I merge the changes if you can let me know. |
Safari defaulted to Unified plan in release 12.1.2, so through this change, we would be adding support for 12.1.2 and higher. |
We're also really looking forward to this feature. In light of COVID-19 we're trying to hold our conferences remotely. And we want to use Jitsi Meet but couldn't so far since half the team is using Safari. Full Safari support couldn't come at a better time. 🙂 |
No - it's mainly for full Safari support (>12.1.2) as we're in the same situation as @A1bi is |
Folks, putting more preasure on a team which is already under a lot of stress these days is not really a recipe for success. I get it, you want to use Safari. We want to support it, we are working on it, but claiming you can't use Jitsi because we don't support Safari it's a stretch. You can use a different browser on the interim, can't you? |
Yes, and it is superb. A couple of friends have both run up Jitsi instances for their businesses, and they've over the moon with it. Thank you for all your continued hard work on it. It's an amazing piece of open source software. |
I'm sorry my words came across a little harsh. I don't want to put pressure on anyone. Thank you for your hard work. 🙂 Just to explain my situation: Most people in my team are not very tech-savvy unfortunately. I can't just tell them to install and use another browser. But you are right, we will find a way. 🙂 |
@saghul - did in no way try to put more pressure but rather try and see where we could help out testing some of the upcoming features. Truly appreciate all the work you're putting in to this! |
Any update on this? |
4 days ago, the estimate was 1-2 weeks, so I suspect it’ll be a bit longer! I’m sure they’ll post here when it’s ready for testing :) |
Stop it, please. |
It is worth locking this issue (if Github supports that?) until you have an update? It's clearly on people's minds, but the pressure cannot be helping. |
any news on this ? extremely important, can you create a branch so we can help ? |
I'm locking this because people don't seem to comprehend that asking more times won't solve it quicker. It will be ready when it's ready. |
This issue has been fixed. |
There is no need for plugins in latest Safari on desktop and mobile but it still shows a notification that Safari requires a plugin.
The text was updated successfully, but these errors were encountered: