Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture-in-Picture (PIP) doesn't work in Android app (with jitsi-meet-sdk) after screen sharing #9099

Closed
xpst opened this issue Apr 28, 2021 · 10 comments

Comments

@xpst
Copy link

xpst commented Apr 28, 2021

Description:

It is not possible to switch to PIP mode after screen sharing - when screen sharing is stopped.

Steps to reproduce:

  1. Connect to a room
  2. Click Start screen sharing
  3. Click Stop screen sharing
  4. Try to switch to PIP mode

Expected behavior:

App is switched to PIP mode

Actual behavior:

No reaction on PIP button click.

It looks like PIP is disabled during screen sharing and it is not enabled after screen sharing is stopped.

Server information:

https://meet.jit.si

Client information:

Verified on the latest JitsiSDKTest with SDK version 3.4.0:
https://github.com/jitsi/jitsi-meet-sdk-samples/tree/master/android/java/JitsiSDKTest

Additional information:

jitsi_issue_20210428

@xpst xpst changed the title Picture-in-Picture (PIP) doesn't work after screen sharing Picture-in-Picture (PIP) doesn't work in Android app (with jitsi-meet-sdk) after screen sharing Apr 28, 2021
@saghul
Copy link
Member

saghul commented Apr 28, 2021

Ping @tmoldovan8x8

@tmoldovan8x8
Copy link
Contributor

Hi @xpst, thanks for pointing this to us. It is valid and will have a look at it.

@kimtrantrong
Copy link

kimtrantrong commented Aug 31, 2021

I have the same problem with version 3.8.0

@bharathraj-e
Copy link

Got a trick 😊

I just commented out the line which disables Pip during screen share.

react/features/base/conference/middleware.native.js

line no : 56

// setPictureInPicture(true)

@saibotma
Copy link

Same issue on iOS.

@saghul
Copy link
Member

saghul commented Nov 29, 2021

Same issue on iOS.

iOS doesn't really implement PiP, the app needs to upon receiving the corresponding event. Do you not get the event?

@saibotma
Copy link

saibotma commented Dec 2, 2021

The button to minimize Jitsi into “fake” PiP in iOS does not work either, after screen sharing. That's what I wanted to say.

@saghul
Copy link
Member

saghul commented Dec 2, 2021

Gotcha.

@saghul
Copy link
Member

saghul commented Dec 2, 2021

@tmoldovan8x8 Can you PTAL?

@tmoldovan8x8
Copy link
Contributor

Fixed and it should be available in the next release #10516

@saghul saghul closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants