Busy Lamp Field Bug (Exception)

[darrenhollick]

Description

I'm working with Jitsi Desktop and I'm trying to get the Busy Lamp Field working. I have an account registered with our Asterisk 13 server and can make and receive calls. I have configured Jitsi to use a provisioning file and it successfully gets that file (confirmed by looking at the Property Editor).

The contents of the config file are below:

Config File Contents (click to expand)

##################
#  BLF Settings  #
##################
net.java.sip.communicator.plugin.busylampfield.ENABLED=true
net.java.sip.communicator.impl.protocol.sip.acc1543355484566.BLF_ENABLED=true
net.java.sip.communicator.impl.protocol.sip.acc1543355484566.BLF_LINE.blf001.Name=DND
net.java.sip.communicator.impl.protocol.sip.acc1543355484566.BLF_LINE.blf001.Group=
net.java.sip.communicator.impl.protocol.sip.acc1543355484566.BLF_LINE.blf001.Address=*76999
net.java.sip.communicator.impl.protocol.sip.acc1543355484566.BLF_LINE.blf001.Pickup=\1

This causes the GUI to behave strangely (It lags like crazy and fails to render the UI) and the the BLF is not properly displaying the hinted status. I can tell from the Asterisk server that the hint was successfully subscribed to by running the command core show hints.

I did notice in the Jitsi log files that there is a null reference exception being thrown repeatedly.

Exception Details (click to expand)

2018-11-27 17:28:59.264 SEVERE: [613] util.UtilActivator.uncaughtException().122 An uncaught exception occurred in thread=Thread[AWT-EventQueue-0,6,main] and message was: null
java.lang.NullPointerException
    at net.java.sip.communicator.plugin.busylampfield.CustomActionsBLFSourceContact$PickupAction.isVisible(CustomActionsBLFSourceContact.java:193)
    at net.java.sip.communicator.plugin.busylampfield.CustomActionsBLFSourceContact$PickupAction.isVisible(CustomActionsBLFSourceContact.java:90)
    at net.java.sip.communicator.impl.gui.main.contactlist.contactsource.ExternalContactSource.isContactActionVisible(ExternalContactSource.java:305)
    at net.java.sip.communicator.impl.gui.main.contactlist.contactsource.ExternalContactSource.getContactCustomActionButtons(ExternalContactSource.java:210)
    at net.java.sip.communicator.impl.gui.main.contactlist.contactsource.SourceUIContact.getContactCustomActionButtons(SourceUIContact.java:735)
    at net.java.sip.communicator.impl.gui.main.contactlist.ContactListTreeCellRenderer.initButtonsPanel(ContactListTreeCellRenderer.java:1147)
    at net.java.sip.communicator.impl.gui.main.contactlist.ContactListTreeCellRenderer.getTreeCellRendererComponent(ContactListTreeCellRenderer.java:576)
    at net.java.sip.communicator.impl.gui.main.contactlist.TreeContactList.dispatchEventToButtons(TreeContactList.java:1796)
    at net.java.sip.communicator.impl.gui.main.contactlist.TreeContactList.mouseMoved(TreeContactList.java:1663)
    at java.awt.AWTEventMulticaster.mouseMoved(AWTEventMulticaster.java:330)
    at java.awt.AWTEventMulticaster.mouseMoved(AWTEventMulticaster.java:329)
    at java.awt.Component.processMouseMotionEvent(Component.java:6578)
    at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3342)
    at java.awt.Component.processEvent(Component.java:6302)
    at java.awt.Container.processEvent(Container.java:2236)
    at java.awt.Component.dispatchEventImpl(Component.java:4889)
    at java.awt.Container.dispatchEventImpl(Container.java:2294)
    at java.awt.Component.dispatchEvent(Component.java:4711)
    at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
    at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4538)
    at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
    at java.awt.Container.dispatchEventImpl(Container.java:2280)
    at java.awt.Window.dispatchEventImpl(Window.java:2746)
    at java.awt.Component.dispatchEvent(Component.java:4711)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
    at java.awt.EventQueue.access$500(EventQueue.java:97)
    at java.awt.EventQueue$3.run(EventQueue.java:709)
    at java.awt.EventQueue$3.run(EventQueue.java:703)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
    at java.awt.EventQueue$4.run(EventQueue.java:731)
    at java.awt.EventQueue$4.run(EventQueue.java:729)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

---

Current behavior

The GUI stops updating and becomes almost completely unresponsive. Usually you can't even see the BLF drawn in the GUI but if you ever do it definitely doesn't render updates. (InUse/Idle) If I disable the BLF features the app works great and there are no rendering glitches.

---

Expected Behavior

BLF entries should show as "contacts" and they should toggle between on/off as the hint from the server changes. The GUI should remain responsive and render correctly.

---

Possible Solution

Track down and fix the exception listed above.

---

Steps to reproduce

1. Remove %USERPROFILE%\AppData\Local\Jitsi
2. Remove %USERPROFILE%\AppData\Roaming\Jitsi
3. Fresh Install Jitsi
4. Configure Online Provisioning and include the config settings listed above (plus sip account information)
5. Restart Jitsi
6. The configured BLFs may or may not be visible at this point... however switching to the "history" screen and back will demonstrate the GUI failing to render correctly.

---

Environment details

• Jitsi 2.10.5550 running on Windows 10 Pro x64 (OS build 17134.407)
• Asterisk 13

---