Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't find Instance method 'fromUnparsedString' in swift3.2 branch #11

Closed
KarlZeo opened this issue Jun 27, 2017 · 7 comments
Closed

can't find Instance method 'fromUnparsedString' in swift3.2 branch #11

KarlZeo opened this issue Jun 27, 2017 · 7 comments
Assignees

Comments

@KarlZeo
Copy link

KarlZeo commented Jun 27, 2017

I use swift3.2 branch,but i can't find fromUnparsedString this Instance method.

@Jitsusama
Copy link
Owner

Hello @KarlZeo

I do believe that method is missing right now. The Swift 3.2 branch is currently a major deviation from the master branch's API. I'm focusing on the bare minimum to support Swift 3.2, removing a lot of older API.

That said, I am thinking about reintroducing some of it. I will admit, I wasn't expecting anyone to be using fromUnparsedString directly. I guess that's what I get for not marking it as private! 😄

Let me mull this over a bit. I was thinking of removing that method, but if it is seeing use, I could entertain keeping it around for a while. Are there any other methods that you're used to using that are missing?

@KarlZeo
Copy link
Author

KarlZeo commented Jun 28, 2017

Hi, @Jitsusama
I use NEKit,this repo is use your code.And some IPRange method use fromUnparsedString this method.

@Jitsusama
Copy link
Owner

I see that they copied over UInt128.swift into their source. I'll take a closer look when I get the basic Swift 3.2 functionality working in the swift3.2 branch. I'm thinking that I'll probably reintroduce the method and mark it as deprecated to give that project time to implement API changes in this library.

@Jitsusama Jitsusama self-assigned this Jun 28, 2017
@KarlZeo
Copy link
Author

KarlZeo commented Jun 28, 2017

@Jitsusama OK,Thanks.

@Jitsusama
Copy link
Owner

I just committed e28166f which reintroduces this method as deprecated. Anyone compiling code referencing fromUnparsedString(_: String) in Swift 3.2+ will get a warning, but the code will still compile. Could you please try this out and let me know if it works for you?

@Jitsusama
Copy link
Owner

Hello @KarlZeo, have you had a chance to try this out?

@Jitsusama
Copy link
Owner

I'm closing this out, as it should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants