New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible issue #46
Comments
Ok, played many days OK without using the program. Today launched it and....Elite got broken. So chances this program breaks game by too long reading are good. |
Sounds to me Elite needs to handle file access gracefully with a retry or a writelock. Can't go with reading while data is being written to the file. The read time is already very low and only triggered after a write. Will have to see how FDev resolves the issue on their end. |
Yeh,
So in fact you need something which may read once per 5 seconds, not more often for example. So watcher should set atomic flag, then separated reader thread will check it, read/clear if set, pass to process, sleep for 5 seconds. Because if game writes alot you get notify alot and on each u trigger whole file open/read. |
Additional patch to make my idea with separated thread |
Issue expired @ frontier. Still not seen any evidence, only suspicions. |
Well, just possible issue, maybe nothing.
https://issues.frontierstore.net/issue-detail/39579
Happened to me twice, both times it was 5+ hours of intensive playing. Both times journal files were close to 2Mb. Both times I ran new tool ed-odyssey-materials-helper/
My current idea is, "new tool" reads file too long, so game tries to write, fails and never repeats write again.
So could you recheck read code if it gets exclusive read access which may break game and/or replace with in-ram caching of whole file then parsing it from ram (to minimize time of file access).
The text was updated successfully, but these errors were encountered: