-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto release version with Hasura #32
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
@aaronhayes Thank you very much for detail suggestion :) I've considered the auto-publish as well. However, I concluded not to do so. Once an npm package is published, it can't be edited. This made me try to be as safe as possible. But I am sure this decision is not fixed, so want to keep the issue open for a while. |
@jjangga0214 that makes sense, appreciate the thought you've put into that! Maybe there is a solution somewhere in between? If we used cron jobs to create the PR, we would still have a manual gate. |
It looks like, unless something major changes upstream, the PR only needs to bump the package version number, so unless I'm mistaken (@jjangga0214 may correct me here) it only takes a few seconds anyway. See PR #43 |
But not to release. ATM there are 3 (three!) PR for update to 1.3.2. Every one fail for some reason. I think it's not sustainable.
I think it can be validated with regexp. And how about to add a zero at the end? Like |
It would be great to have the automatic releases, so that we don't need to fallback to manual installs across team when we need the new features 🙏 It wouldn't just make it more usable, but also more sustainable for @jjangga0214 given how fast Hasura releases new versions, it's not just As for the discussed reliability, a regexp check if it's a proper release EDIT: Fixed regexps :) |
It seems to me that an automatic PR creation, would be sufficient. |
@aaronhayes @zenflow @Bessonov @iki @glassmonkey I've taken a conservative attitude because publishing is irreversible. Thank you! |
It would be great to have this package auto publish every time Hasura releases a new version. This should be possible using GitHub Actions + CronJobs.
A good starting reference:
https://github.com/peter-evans/create-pull-request/blob/master/docs/examples.md#use-case-create-a-pull-request-to-update-x-periodically
The text was updated successfully, but these errors were encountered: