Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped 1 attribute entry because it was invalid or would have exceeded field limit (128) error #11

Open
abh opened this issue Jan 1, 2024 · 1 comment

Comments

@abh
Copy link
Contributor

abh commented Jan 1, 2024

Despite my best efforts I've accumulated a few errors like

Dropped 1 attribute entry because it was invalid or would have exceeded field limit (128)

It'd be really helpful if the error could be accompanied with the name of the span and the name of the attribute. It's a lot of tedium to track down these errors without.

(I see in the code why it's not; but if the code noticing the problem can't produce a useful log maybe it could return an appropriate error to the calling code to do the logging instead? I don't know what the modern Perl way of doing that is anymore!)

@jjatria
Copy link
Owner

jjatria commented Feb 12, 2024

Hm, yeah, I was myself a little torn on this, but it's true that the way it currently behaves means tracking things down is harder. I think the big problem is that this is an area where it's easy to go from not enough logging to way too much logging (this is the reason why we don't log undefined values, for example, although technically we probably should).

We should also look into how other implementations handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants