Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AuditlogHistoryField to block cascading deletes #172

Merged
merged 1 commit into from Mar 27, 2018

Conversation

kbussell
Copy link
Contributor

Fixes #108

Thanks to @andrewwatts for suggesting and researching the approach.

Fixes jazzband#108

Thanks to @andrewwatts for suggesting and researching the approach.
@codecov-io
Copy link

Codecov Report

Merging #172 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   83.26%   83.43%   +0.16%     
==========================================
  Files          19       19              
  Lines         508      513       +5     
==========================================
+ Hits          423      428       +5     
  Misses         85       85
Impacted Files Coverage Δ
src/auditlog/models.py 83.42% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc886fa...1e89fd7. Read the comment docs.

Copy link
Contributor

@audiolion audiolion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow awesome PR, I have nothing to even say here so I am gonna shut up and merge 👍

@audiolion audiolion merged commit 3a82338 into jazzband:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants