Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge jjohannes/missing-metadata-guava into this plugin #2

Closed
vlsi opened this issue Apr 4, 2022 · 3 comments
Closed

Merge jjohannes/missing-metadata-guava into this plugin #2

vlsi opened this issue Apr 4, 2022 · 3 comments
Labels
a:rule One or more metadata rules that should be added or updated
Milestone
1.0

Comments

@vlsi
Copy link

vlsi commented Apr 4, 2022

Looks like https://github.com/jjohannes/missing-metadata-guava is related, and the name of java-ecosystem-capabilities sounds good for an umbrella project.
@jjohannes
Copy link
Member

Thanks for the feedback! Will give this give this some thoughts (also related to #1).

@jjohannes
Copy link
Member

jjohannes commented Oct 27, 2022 •
edited

I think I would like to do this for a potential 1.0.

@jjohannes jjohannes added this to the 1.0 milestone Oct 27, 2022
@jjohannes jjohannes changed the title Should jjohannes/missing-metadata-guava be merged here? Merge jjohannes/missing-metadata-guava into this plugin Oct 27, 2022
@jjohannes jjohannes added the a:rule One or more metadata rules that should be added or updated label Oct 27, 2022
@jjohannes
Copy link
Member

missing-metadata-guava covers two aspects compared to the other rules in this plugin:

  1. Capabilities around Guava (fit in here well)
  2. Add additional variant information (android vs standard-jvm)

The first fits perfectly in here. The second is a bit different compared to other rules and is strictly not directly about Capabilities only. But it is very related so I think it fits in here as well.

jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Add functionality from 'missing-metadata-guava' plugin
9ab3489 
See: https://github.com/jjohannes/missing-metadata-guava

#2
jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Add tests from 'missing-metadata-guava' plugin
16c1561 
See: https://github.com/jjohannes/missing-metadata-guava

#2
jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Do not add Jvm Version attribute to Guava metadata
0622989 
Setting both JVM Version and JVM Environment do different values
(which are mostly compatible) creates to much ambiguity for Gradle
to make a clean/good selection in some case.
JVM Environment is the important bit.

Related to #2
jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Add functionality from 'missing-metadata-guava' plugin
c49c401 
See: https://github.com/jjohannes/missing-metadata-guava

#2
jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Add tests from 'missing-metadata-guava' plugin
c058267 
See: https://github.com/jjohannes/missing-metadata-guava

#2
jjohannes added a commit that referenced this issue Nov 4, 2022
@jjohannes
Do not add Jvm Version attribute to Guava metadata
01beb55 
Setting both JVM Version and JVM Environment do different values
(which are mostly compatible) creates to much ambiguity for Gradle
to make a clean/good selection in some case.
JVM Environment is the important bit.

Related to #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:rule One or more metadata rules that should be added or updated
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@vlsi @jjohannes