Fix openepaperlink.eu proxy on https proxies #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed location.protocol: you can use the relative URL //openepaperlink.eu/getupdate/?url= without specifying the protocol (http: or https:) in JavaScript when using the fetch() function. This is because the browser will automatically use the same protocol (HTTP or HTTPS) as the current page. Also, reverted the http:// url in line 287 because that's an url that is called by the esp32, not the browser.
|
Thanks for fixing. I refixed it a little bit ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser don't like to make http request when on a https connection. This fixes that. We probably could also always make a https connection, but that might cause issues if e.g. the server certificate runs out. Then at least local http access will still work.
The file editor does not work yet, I hope to fix it in the future.