Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when linking against htscodecs2 version 1.3.0 #50

Closed
tillea opened this issue Oct 28, 2022 · 3 comments
Closed

Issue when linking against htscodecs2 version 1.3.0 #50

tillea opened this issue Oct 28, 2022 · 3 comments

Comments

@tillea
Copy link

tillea commented Oct 28, 2022

Hi,
as Bernhard Übelacker nicely explained in a Debian bug report io_lib either needs a patch or probably better htscodecs2 should expose the said functions explicitly.
Kind regards, Andreas.

@jkbonfield
Copy link
Owner

I forgot about this, thanks. Io_lib should definitely update to use the newer function names.

@jkbonfield
Copy link
Owner

jkbonfield commented Oct 31, 2022

In the commentary for the patch, it suggests the correct solution is adding these functions to the public header files for htscodecs.

At the time (IIRC) htscodecs was adopted as a formal part of Samtools et al, we also renamed these functions to not be so generic and make it more robust when htslib is used in conjunction with other packages (see samtools/htscodecs#36). That's quite a common scenario, and we've hit issues before with lack of sensible name-spacing of external symbols. Removing them from the header file is essentially a warning that they're going, and likely in a future release will be culled permanently, while retaining ABI compatibility (but I didn't think that through). Perhaps this would have been better handled with compiler-specific flags to mark them as deprecated, but given the transitory nature I hope for now we can just ignore the change there and deal with it properly whenever we next need to do an ABI-breaking change.

I'll incorporate the patch, along with an additional update. Many thanks.

@jkbonfield
Copy link
Owner

Fixed in 9f30677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants