add support for client SSL certificate and key

[matleh]

Added two parameters --ssl-cert and --ssl-key which allow to pass through the client side SSL certificate and key to requests.

Not sure how to test this with unittests.

Maybe naming of the parameters can be improved?

[jkbrzt]

It would be good to specify also type=FileType() so that it fails with a user-friendly error message when the file does not exist or is not readable.

[matleh]

@jkbr thanks for your suggestions. I modified my changes. Instead of using FileType from argparse, I wrote a little existing_file function, which produces nicer output in case of an error.

Not sure, if utils is the right place for existing_function or if you would rather have it in cli since it is only used there.

[jkbrzt]

Maybe readable_file_arg would be a better name? (It has to both exist and be readable by the current user, and also it's tied to argparse .)

As for the location, I think httpie.input would be a good place.

[matleh]

@jkbr Thanks again for your review. I made adjustments according to your feedback.

[jkbrzt]

Great, thanks!

Would you mind documenting it under HTTPS in the README please?

Relevant part of python-requests docs for inspiration: http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification

As for the naming, yeah maybe it could be improved.

[matleh]

@jkbr would you like --cert and --privkey better as parameter names? --cert would be in line with requests parameter names but maybe it is not so clear that this is about SSL connections. Or maybe --cert and --certkey to make the connection clearer? What do you think?

[matleh]

I just went ahead and renamed the parameters to --cert and --certkey since I found these the most concise and in line with the requests library. Also added documentation.

[jkbrzt]

Thanks @matleh! Let's go with these names for now. It can be renamed if we can think of anything better.

Could you also update CHANGELOG and add yourself to AUTHORS? Also, if you added just a couple of tests, that would be awesome :)

[matleh]

I updated CHANGELOG and AUTHORS. Adding tests is not so trivial. Have to find a way to test SSL.

[jkbrzt]

Thanks @matleh!

[jkbrzt]

As for the tests, it's not necessary to test the actual SSL functionality. Testing of the handling of the arguments will do. I'll look into that.

[matleh]

If you mean it would be sufficent to mock out requests and check that it is called the right way - I think, I can do that. Just let me know.

[jkbrzt]

@matleh Yep, something like that would do the trick. Thanks!