Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL feature #217

Closed
wants to merge 11 commits into from
Closed

Base URL feature #217

wants to merge 11 commits into from

Conversation

nrocco
Copy link

@nrocco nrocco commented May 8, 2014

See for an explanation of the feature (and the use case for it) in issue #215

I, on purpose, implemented the feature separately from the curl shorthand syntax.
The only thing missing in the Pull Request is tests.

@nrocco
Copy link
Author

nrocco commented Jun 11, 2014

Hi there. I am curious if you had chance to look at this PR @jakubroztocil

@jkbrzt
Copy link
Member

jkbrzt commented Jun 13, 2014

@nrocco thanks for the pull request. Sorry I haven't gotten around looking at it, but I will do it soon.

@jkbrzt jkbrzt force-pushed the master branch 3 times, most recently from 518c743 to 24f46ff Compare September 8, 2014 05:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) to 92.19% when pulling dfc4d31 on nrocco:base-url into ab0d1fd on jakubroztocil:master.

@nrocco
Copy link
Author

nrocco commented Mar 21, 2015

Hi @jakubroztocil
Have you had the time to look at my PR which introduces the BASE_URL feature?
Does it still fit the vision of httpie?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) to 91.94% when pulling 45ff58d on nrocco:base-url into d8b819b on jakubroztocil:master.

@nrocco
Copy link
Author

nrocco commented May 17, 2015

Hi @jakubroztocil just checking in to see if this is still on the roadmap.

@grimborg
Copy link

I'm also interested in seeing this feature live.

@heydonovan
Copy link

+1

1 similar comment
@knxroot
Copy link

knxroot commented Aug 27, 2015

+1

@nrocco
Copy link
Author

nrocco commented Oct 22, 2015

Hi @jakubroztocil,

I added unit tests to the pull request. I'd love to see this merged. Is there anything I can help with or need to change for that to happen?

Thanks.

@nrocco
Copy link
Author

nrocco commented Jun 19, 2016

@jkbrzt Will this ever get merged in?

@jkbrzt
Copy link
Member

jkbrzt commented Jul 2, 2016

@nrocco thanks for for the pull request! I think this should be a job for an external wrapper around HTTPie. Have a look at https://github.com/eliangcs/http-prompt which does an amazing job.

@jkbrzt jkbrzt closed this Jul 2, 2016
@noahcoad
Copy link

+1 for this HTTPIE_BASE_URL feature request

@Morantron
Copy link

First of all, I want to say this is an amazing tool!

I think you should reconsider adding this feature @jakubroztocil

Main use case is containers being used more and more for local development, so just having localhost isn't enough.

A tool like http-prompt doesn't fit my workflow because I use a vim+tmux to interact with REPLs. While this approach is kind of niche, the HTTPIE_BASEURL env vars would be a perfectly fine solution. The implementation doesn't seem to add much complexity, and would allow more ways to enjoy httpie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants