Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #496 #516

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Fix Issue #496 #516

merged 1 commit into from
Sep 6, 2016

Conversation

dongweiming
Copy link
Contributor

@dongweiming dongweiming commented Sep 1, 2016

I have same problem like #496 in Python 3.

The argparse.py#L1430 module said:

if kwargs.get('nargs') == ZERO_OR_MORE and 'default' not in kwargs:
    kwargs['required'] = True

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.595% when pulling c53a778 on dongweiming:fix-496 into 5efc901 on jkbrzt:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.595% when pulling c53a778 on dongweiming:fix-496 into 5efc901 on jkbrzt:master.

@jkbrzt jkbrzt merged commit 0d08732 into httpie:master Sep 6, 2016
@jkbrzt
Copy link
Member

jkbrzt commented Sep 6, 2016

Thanks, @dongweiming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants