Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn --verify=False/True to --verify=no/yes #560

Merged
merged 1 commit into from Feb 16, 2017
Merged

Turn --verify=False/True to --verify=no/yes #560

merged 1 commit into from Feb 16, 2017

Conversation

floer32
Copy link

@floer32 floer32 commented Feb 10, 2017

One way to address #559 -- instead of warning or throwing an error, just accept "True" and "False"
as synonyms of yes/no

@jkbrzt
Copy link
Member

jkbrzt commented Feb 13, 2017

@hangtwenty thanks for the pull request. I can understand the confusion. Here's a possibly more robust solution.

https://github.com/jkbrzt/httpie/blob/de38f86730bae524b9cbec317a6275a74987400a/httpie/client.py#L163

        'verify': {
            'yes': True,
            'true': True,
            'no': False,
            'false': False,
        }.get(args.verify.lower(), args.verify),

One way to address #559 -- #559
-- instead of warning or throwing an error, just accept "True" and "False"
as synonyms of yes/no

(Updated to reflect feedback given at #560 )
@jkbrzt jkbrzt merged commit cf8d5eb into httpie:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants